~Gri to Khadafi~

[Daddy]

The modification has been added to the forum source code.
   Many modifications have followed
Removing such code can now be a dangerous task
  Such as a man becomes dependent on a drug
Quitting can kill him.
    Deleting such code can kill a dependency

No changes can safely be made
  Only once we move to SMF2.0 can it be free
The option to "Hide my agent" can be implemented

[gri]

Only once we move to SMF2.0
the option to "Hide my agent" can be implemented

Is there a known mod with the Hide option for 2.X ?

[Clara Listensprechen]

Imagine my surprise when I got an email notification that replies had been added to this topic. Long time no see, gri. Regarding grivitation, is Khadafi now a Toogrian?  

========================================

Oh--I see that he is not and the issue remains the OS Detector.  It's really pretty harmless, gri.  It's not like Putin is sending in tanks after you or anything.

[Daddy]

Is there a known mod with the the the the Hide option for 2.X ?

No,

However I have already had to heavily modify an existing mod in SMF 2.x for Browser Detection.  Given that everything would be a fresh install on 2.x, making individual changes and tweaks to mods is much more simple than what we have now on Boyah (Hundreds of mods being installed/uninstalled over 8 years).  Many authors of SMF mods are fucking terrible programmers who fail to abide by the the coding standards suggested by SMF and it results in really messy code that starts to break after a few mods start altering similar code.


In the case of user agent detection I can most likely add a profile option and an if statement to check if the anonymity is turned on then add a placeholder OS and Browser.

also why are you using XP? it will no longer be patched in a little over a month.

[Clara Listensprechen]

I still use Windows 98 SE and patches for that have been discontinued eons ago.  There are just some things you can do with old systems that have been removed in newer versions.  I'll defend anybody's right to stick with XP if they wanna.

[gri]

{
Have not got the notifications of those two replies
http://boyah.net/forums/index.php/topic,54817.msg1411903.html#msg1411903
http://boyah.net/forums/index.php/topic,54817.msg1411953.html#msg1411953
}

No,
However I have already had to heavily modify
an existing mod in SMF 2.x for Browser Detection.

Was this mod the original one
http://custom.simplemachines.org/mods/index.php?mod=1515
?

[Daddy]

Was this mod the original one
http://custom.simplemachines.org/mods/index.php?mod=1515
?

That's the one I plan to modify and install on SMF2.0

This is the one we have installed and modified now: http://custom.simplemachines.org/mods/index.php?mod=487

[gri]

Display.template.php

Code Select


/*
//K-Detection
if ($message['k_os'])
echo '<b>OS:</b> <br/> <img src="' . $settings['images_url'] . '/K_Detection/icon_', $message['k_os_ico'], '.png" align="top"> ', $message['k_os'], '<br/>';
else
echo '<b>OS:</b> <br/> <img src="' . $settings['images_url'] . '/K_Detection/icon_unknown.png" align="top"> unknown<br/>';
if ($message['k_br'])
echo '<b>Browser:</b> <br/> <img src="' . $settings['images_url'] . '/K_Detection/icon_', $message['k_br_ico'], '.png" align="top"> ', $message['k_br'], '<br/>';
else
echo '<b>Browser:</b> <br/> <img src="' . $settings['images_url'] . '/K_Detection/icon_unknown.png" align="top"> unknown<br/>';
//K-Detection

echo '<br/>';
*/


[Daddy]

1.) I don't think that will do anything because it doesn't even touch user settings.

2.) I'd have to manually modify every theme on 1.1.x for that to work.

3.) I'm at work and don't have the credentials to SSH in, nor would I add my SSH key to boyah's server to my work PC.

[Clara Listensprechen]

Just so y'all know--I just saved this page as HTML to grab the code and discussion context.  Whatever else you might think of gri, he's a pretty fair shake at coding.

[gri]

1.) I don't think that will do anything because it doesn't even touch user settings.

It will only exclude the display of critical data
until the upgrade to 2.X.. without this mod.

2.) I'd have to manually modify every theme on 1.1.x for that to work.

12 themes ?
Uninstall 11 of them.

[Daddy]

1.) I don't think that will do anything because it doesn't even touch user settings.

It will only exclude the display of critical data
until the upgrade to 2.X.. without this mod.

2.) I'd have to manually modify every theme on 1.1.x for that to work.

12 themes ?
Uninstall 11 of them.

1) the code you linked two looks like it will only display the OS if it detects it, which is what already happens. You'd need  to clear your user agent string for that to happen.

2.) wut

[gri]

1) the code you linked to looks like it will only display the OS if it detects it,
which is what already happens.
You'd need  to clear your user agent string for that to happen.

My suggestion is placed exclusively in lines 1 and 14 there.
The inner code modified by you is unknown to me.

[Daddy]

oh lol you commented it out.

I'm not making any code changes until 2.0 

[gri]

I'm not making any code changes until 2.0

What namely have you managed to change in code or in censor list
to stop the multiplication of the "the" word

in the moment between those your statements
   with the attempt to formulate the Truth about SMF coding standarts
   and with your inspiring Decision, though opposite to the correct one:

Many authors of SMF mods are fucking terrible programmers
who fail to abide by the the coding standards suggested by SMF
and it results in really messy code that starts to break
after a few mods start altering similar code.


In the case of user agent detection
I can most likely add a profile option
and an if statement to check if the anonymity is turned on off
then add a placeholder OS and Browser.

?